Merged
Conversation
We will be using GitHub native automerge feature. We also need to remove some webhook events. The ones we still need are: pull_request closed and pull_request labeled For python/core-workflow#498 and #PyConUS #PyConUSChallenge
Codecov Report
@@ Coverage Diff @@
## main #610 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 10 6 -4
Lines 1010 356 -654
Branches 66 23 -43
==========================================
- Hits 1010 356 -654
|
hugovk
reviewed
Apr 19, 2023
tests/test_util.py
Outdated
| to_iterate = self._getiter_return[url] | ||
| for item in to_iterate: | ||
| yield item | ||
| return to_return |
Member
There was a problem hiding this comment.
GH won't allow the suggestion, but we can combine these now:
-to_return = self._getitem_return[self.getitem_url]
-return to_return
+return self._getitem_return[self.getitem_url]Combine return statements
This was referenced Apr 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will be using GitHub native automerge feature.
We also need to remove some webhook events.
The ones we still need are: pull_request closed and pull_request labeled
For python/core-workflow#498 and #PyConUS #PyConUSChallenge