stubtest on windows isn't doing anything

[hauntsaninja]

I think this has been the case for a while, I suspect since they were moved to Github actions in #4223
Example in #4447

[srittau]

@hauntsaninja Do you have any idea why that might be? The output (example) indicates a successful run.

[JelleZijlstra]

I put some debug prints in #4454 and apparently we just never execute any part of stubtest_test.py. There must be something wrong with how we invoke the script in the GitHub action (https://github.com/python/typeshed/blob/master/.github/workflows/stubtest.yml#L27).

[Akuli]

This runs the script correctly on windows and ubuntu: 2dc3d10

but after adding that, stubtest fails to import something on windows: https://github.com/Akuli/typeshed/runs/994228956

[srittau]

Makes sense that it didn't run with Python, since I assume that the default Windows shell doesn't look at the hashbang. It's just strange that there were no errors reported.

[Akuli]

welcome to windows lol

[hauntsaninja]

Thanks for figuring it out Akuli! It looks like we removed dbm.ndbm from the whitelists in #4225, shortly after moving to Github Action. I opened #4455, since stubtest should print "stubtest succeeded" we'll be able to figure out if it ran.

[Akuli]

maybe put it to tests/stubtest_whitelists/win32.txt? dbm.gnu is already there

edit: nevermind you put it there already