Draft
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
commented
Apr 2, 2026
| class methodcaller: | ||
| def __new__(cls, name: str, /, *args: Any, **kwargs: Any) -> Self: ... | ||
| def __call__(self, obj: Any) -> Any: ... | ||
| class methodcaller(Generic[_P, _R]): |
Collaborator
Author
There was a problem hiding this comment.
Making this generic, makes it possible to use better methodcallers in annotations, even if type checking is not perfect:
m: methodcaller[[int], str] = methodcaller("foo") # error (missing argument)I'll add some tests.
srittau
commented
Apr 2, 2026
| m1 = methodcaller("foo") | ||
| assert_type(m1, methodcaller[[], Any]) | ||
| m2 = methodcaller("foo", 42, bar="") | ||
| # assert_type(m2, methodcaller[[int, Arg(str, "bar")], Any]) |
Collaborator
Author
There was a problem hiding this comment.
Is there a way to specialize a ParamSpec's kwargs in older Python versions?
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
I'm not sure why pyright has problems here. microsoft/pyright#11358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.