Add options "undef", "replace" form CSV#open#90
Closed
yuuna wants to merge 1 commit intoruby:masterfrom
Closed
Conversation
kou
requested changes
Apr 20, 2019
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
Thanks for your report.
Could you check my comments?
| strip: false) | ||
| strip: false, | ||
| undef: nil, | ||
| replace: nil) |
Member
There was a problem hiding this comment.
Do we need to accept :undef and :replace in CVS#initialize?
It seems that we just need to accept them in CSV.open. Then we can remove them from options in CSV.open arguments.
Author
There was a problem hiding this comment.
I will fix the arguments in CSV.open.
| rows << row | ||
| end | ||
| assert_equal(@rows, rows) | ||
| end |
Member
There was a problem hiding this comment.
We need to new test data that fails without these new options.
Member
|
Orphan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use CSV#open with undef: :repace, replace: "*" options form wrong character.