Skip to content

Accept Pathname object as rule's prerequisite#528

Open
gemmaro wants to merge 1 commit intoruby:masterfrom
gemmaro:feat/rule-pathname
Open

Accept Pathname object as rule's prerequisite#528
gemmaro wants to merge 1 commit intoruby:masterfrom
gemmaro:feat/rule-pathname

Conversation

@gemmaro
Copy link
Copy Markdown
Contributor

@gemmaro gemmaro commented Dec 15, 2023

Hello,

This change allows the rule to accept a Pathname object as a prerequisite.

foo = Pathname("foo")

# before
rule ".o" => [".c", foo.to_s] do |t|
  # ...
end

# after
rule ".o" => ["c", foo] do |t|
  # ...
end

Thank you,

@gemmaro gemmaro changed the title Accept Pathname-like object as rule's prerequisite Accept Pathname object as rule's prerequisite Dec 16, 2023
@gemmaro gemmaro force-pushed the feat/rule-pathname branch 2 times, most recently from a1df689 to 73ee66c Compare December 20, 2023 10:43
@hsbt hsbt force-pushed the feat/rule-pathname branch from 73ee66c to b9477ce Compare March 15, 2024 00:39
@gemmaro
Copy link
Copy Markdown
Contributor Author

gemmaro commented Dec 29, 2024

I rebased to the latest master branch. Feel free to let me know if there is anything that needs to be done to merge.

@hsbt
Copy link
Copy Markdown
Member

hsbt commented Apr 3, 2026

@gemmaro Can you revert 27d0e0e? Renaming is out of scope at this feature request.

@gemmaro gemmaro force-pushed the feat/rule-pathname branch from 27d0e0e to a2247ab Compare April 3, 2026 01:45
@gemmaro
Copy link
Copy Markdown
Contributor Author

gemmaro commented Apr 3, 2026

@hsbt Sure, I dropped the renaming commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants