Avoid missed wakeup with fiber scheduler and Fiber.blocking.#6588
Merged
ioquatix merged 3 commits intoruby:masterfrom Oct 20, 2022
Merged
Avoid missed wakeup with fiber scheduler and Fiber.blocking.#6588ioquatix merged 3 commits intoruby:masterfrom
ioquatix merged 3 commits intoruby:masterfrom
Conversation
ioquatix
force-pushed
the
fiber-scheduler-blocked-fixes
branch
from
2532e96 to
5549b8b
Compare
tenderlove
pushed a commit
to Shopify/ruby
that referenced
this pull request
Oct 27, 2022
* Ensure that blocked fibers don't prevent valid wakeups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we enter a sync wakeup, ensure that the fiber is only captured if it's non-blocking at the time of entry, rather than at the time of wakeup. Otherwise, if you inadvertently try to wake up a fiber which has invoked
Fiber.blocking, you may deadlock. This only happens in very rare situations, the only reproduction I could make was blocking inScheduler#kernel_sleep.