Support forwarded arguments in calls, super, and nested blocks#416
Open
pvcresin wants to merge 2 commits intoruby:masterfrom
Open
Support forwarded arguments in calls, super, and nested blocks#416pvcresin wants to merge 2 commits intoruby:masterfrom
pvcresin wants to merge 2 commits intoruby:masterfrom
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known issue:
forwarding-argumentsSummary
...in direct calls,super(...), and nested blocksbar(...),super(...), and1.times { bar(...) }Design
...as forwarded actual arguments instead of reconstructing it from local variablesLocalEnvsuper(...)and nested block bodiesNote
The implementation is based on the existing argument-binding logic in
MethodDefBox#pass_arguments.ForwardingArguments#accept_actual_argumentsmirrors that flow to capture the actual arguments received bydef foo(...), andForwardingArguments#to_actual_argumentsconverts that captured state back intoActualArgumentsfor direct calls,super(...), and nested block calls.