Remove rustc_on_unimplemented's append_const_msg#154653
Open
mejrs wants to merge 3 commits intorust-lang:mainfrom
Open
Remove rustc_on_unimplemented's append_const_msg#154653mejrs wants to merge 3 commits intorust-lang:mainfrom
mejrs wants to merge 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
This PR modifies cc @jieyouxu Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
mejrs
commented
Mar 31, 2026
Comment on lines
2828
to
2833
| fn get_standard_error_message( | ||
| &self, | ||
| trait_predicate: ty::PolyTraitPredicate<'tcx>, | ||
| message: Option<String>, | ||
| predicate_constness: Option<ty::BoundConstness>, | ||
| append_const_msg: Option<AppendConstMessage>, | ||
| post_message: String, | ||
| long_ty_path: &mut Option<PathBuf>, |
Contributor
Author
There was a problem hiding this comment.
This function was always called with one of message and predicate_constness being None, thus making much of the code here unreachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does nothing because it is unreachable within the compiler. It also doesn't seem that useful since all the traits it was on are
constnow.Will make pr to rustc-dev-guide docs later.