Skip to content

hwaddress: automatically add -Ctarget-feature=+tagged-globals#154677

Open
Darksonn wants to merge 1 commit intorust-lang:mainfrom
Darksonn:hwasan-tagged-globals
Open

hwaddress: automatically add -Ctarget-feature=+tagged-globals#154677
Darksonn wants to merge 1 commit intorust-lang:mainfrom
Darksonn:hwasan-tagged-globals

Conversation

@Darksonn
Copy link
Copy Markdown
Member

@Darksonn Darksonn commented Apr 1, 2026 •
edited by rustbot
Loading

Note that since HWAddressSanitizer is/should be a target modifier, we do not have to worry about whether this LLVM target feature changes the ABI.

Fixes: #148185

@Darksonn Darksonn added the A-sanitizers Area: Sanitizers for correctness and code quality label Apr 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

Some changes occurred in src/doc/unstable-book/src/compiler-flags/sanitizer.md

cc @rust-lang/project-exploit-mitigations, @rcvalle

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 13 candidates

@Darksonn Darksonn mentioned this pull request Apr 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-sanitizers Area: Sanitizers for correctness and code quality PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically add -C target-feature=+tagged-globals when -Z sanitizer=hwaddress is used

3 participants

@Darksonn @rustbot @davidtwco