Skip to content

v0.6.16: bullmq optionality#3842

Merged
icecrasher321 merged 1 commit intomainfrom
staging
Mar 30, 2026
Merged

v0.6.16: bullmq optionality#3842
icecrasher321 merged 1 commit intomainfrom
staging

Conversation

@icecrasher321
Copy link
Copy Markdown
Collaborator

fix(bullmq): disable temporarily (#3841)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 30, 2026 4:30pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 30, 2026

PR Summary

Medium Risk
Changes backend selection for async jobs and dispatch paths by disabling BullMQ unless explicitly enabled, which could alter execution timing and throughput in production if the flag is misconfigured.

Overview
BullMQ usage is now explicitly opt-in: isBullMQEnabled() requires both REDIS_URL and the new CONCURRENCY_CONTROL_ENABLED env var to be truthy.

Adds CONCURRENCY_CONTROL_ENABLED to env (defaulting to 'false'), effectively forcing callers that check isBullMQEnabled() to fall back to the non-BullMQ path unless the flag is turned on.

Written by Cursor Bugbot for commit c4f4e6b. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 30, 2026

Greptile Summary

This PR temporarily disables BullMQ-based concurrency control by introducing a new CONCURRENCY_CONTROL_ENABLED environment variable (defaulting to 'false'), ensuring BullMQ remains inactive even when REDIS_URL is configured.

Key changes:

  • env.ts: Adds CONCURRENCY_CONTROL_ENABLED optional env var with a default of 'false' under the Admission & Burst Protection section.
  • connection.ts: isBullMQEnabled() now requires both CONCURRENCY_CONTROL_ENABLED=true and a valid REDIS_URL to activate BullMQ. The existing isTruthy utility is correctly used to handle the t3-env string coercion behaviour.

No logic or correctness concerns were found. The change is minimal, well-scoped, and cleanly reverts to inline execution by default without removing infrastructure code.

Confidence Score: 5/5

Safe to merge — the change is a simple feature flag defaulting BullMQ to disabled, with no logic errors or side-effects.

Both files have trivial, correct changes: a new optional env var with a safe default and a one-line guard added to isBullMQEnabled(). The isTruthy helper handles string 'false' correctly (returns false), so BullMQ is off by default as intended. No P0 or P1 findings were identified.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/lib/core/bullmq/connection.ts Adds CONCURRENCY_CONTROL_ENABLED guard to isBullMQEnabled() so BullMQ is off by default even when REDIS_URL is set; imports isTruthy helper correctly.
apps/sim/lib/core/config/env.ts Adds CONCURRENCY_CONTROL_ENABLED optional env var (defaults to 'false') under the Admission & Burst Protection section with a clear comment.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[isBullMQEnabled called] --> B{CONCURRENCY_CONTROL_ENABLED\n== 'true'?}
    B -- No\n(default: 'false') --> C[Return false\nInline execution used]
    B -- Yes --> D{REDIS_URL set?}
    D -- No --> E[Return false]
    D -- Yes --> F[Return true\nBullMQ active]
Loading

Reviews (1): Last reviewed commit: "fix(bullmq): disable temporarily (#3841)" | Re-trigger Greptile

@icecrasher321 icecrasher321 merged commit 1d7ae90 into main Mar 30, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant