feat(infra): add dev environment support#3867
Conversation
PR SummaryMedium Risk Overview Updates Written by Cursor Bugbot for commit 158e4df. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adfd2b7 to
a247646
Compare
Greptile SummaryThis PR adds Key changes:
The implementation is consistent across both workflow files and the previous concern about Confidence Score: 5/5Safe to merge — changes are well-scoped, consistent across both workflow files, and the prior new URL() crash concern has been addressed. No P0/P1 findings. The isHosted logic is correct (.endsWith('.sim.ai') with a leading dot prevents false positives), the three-way AWS credential expressions follow the established pattern, and the ECR tag elif correctly prevents dev from falling through to :staging. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Git Push / PR] --> B{Branch?}
B -- main --> C[AWS_ROLE_TO_ASSUME\nAWS_REGION]
B -- dev --> D[DEV_AWS_ROLE_TO_ASSUME\nDEV_AWS_REGION]
B -- staging --> E[STAGING_AWS_ROLE_TO_ASSUME\nSTAGING_AWS_REGION]
C --> F[ECR Tag: latest]
D --> G[ECR Tag: dev]
E --> H[ECR Tag: staging]
F --> I[GHCR tags + manifests\nmain only]
G --> J[ECR push only]
H --> J
K[NEXT_PUBLIC_APP_URL] --> L{Parse hostname}
L -- valid URL --> M{hostname == sim.ai\nor endsWith .sim.ai?}
L -- invalid / empty --> N[isHosted = false]
M -- yes --> O[isHosted = true]
M -- no --> N
Reviews (2): Last reviewed commit: "fix(ci,feature-flags): guard URL parse, ..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
Summary
Type of Change
Testing
Tested manually — dev environment deployed at `dev.sim.ai`, Docker images building and pushing `:dev` tag to ECR correctly, `isHosted` verified for `www.sim.ai`, `staging.sim.ai`, and `dev.sim.ai`
Checklist