Skip to content

update androidx.sqlite/sqlite -> 2.1.0#501

Merged
developernotes merged 1 commit intosqlcipher:masterfrom
brody2consult:patch-1
Jan 10, 2023
Merged

update androidx.sqlite/sqlite -> 2.1.0#501
developernotes merged 1 commit intosqlcipher:masterfrom
brody2consult:patch-1

Conversation

@brody2consult
Copy link
Copy Markdown

@brody2consult brody2consult commented Mar 24, 2020

UPDATED January 2023:

I think it would be ideal to update this androidx.sqlite/sqlite to 2.2.0, but it looks to me like this would incur a requirement for Android SDK 31. I am not sure if we are ready for this kind of breaking change yet.

This is just a suggestion to use the latest version of androidx.sqlite from https://mvnrepository.com/artifact/androidx.sqlite/sqlite. This worked for me when using my custom build in an Apache Cordova test project. I hope I will have a chance to test an AAR with the test suite in sqlcipher-android-tests in the near future, no promises due to some urgent project work. I am raising this as a draft PR for now.

@commonsguy
Copy link
Copy Markdown
Collaborator

I think we need to make some modifications for this to work. If nothing else, they added useNoBackupDirectory to SupportSQLiteOpenHelper.Configuration. We probably need to honor that.

@brody2consult brody2consult changed the title androidx.sqlite:sqlite:2.1.0 update [WIP] androidx.sqlite:sqlite:2.1.0 update Mar 24, 2020
@piotr-pawlowski
Copy link
Copy Markdown

Please consider update androidx.sqllite to 2.1.0.

Here is an example of implementation for useNoBackupDirectory:
https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.java#61

@developernotes
Copy link
Copy Markdown
Member

Hello @piotr-pawlowski

We are just finishing efforts on the next public SQLCipher release. Unfortunately, an update to the androidx.sqlite dependency will need to occur in a follow-up release. We have added it to our backlog. Thanks!

@brody2consult brody2consult deleted the patch-1 branch January 12, 2021 17:20
@epicstar
Copy link
Copy Markdown

epicstar commented May 25, 2021

Hello. I noticed that this was closed. Is androidx.sqlite updated to 2.1.0?

@brody2consult brody2consult restored the patch-1 branch May 25, 2021 17:22
@brody2consult brody2consult reopened this May 25, 2021
@brody2consult brody2consult changed the title [WIP] androidx.sqlite:sqlite:2.1.0 update androidx.sqlite/sqlite 2.1.0 update May 25, 2021
@brody2consult brody2consult marked this pull request as ready for review May 25, 2021 17:26
@brody2consult
Copy link
Copy Markdown
Author

Nope, just reopened.

@brody2consult brody2consult changed the title androidx.sqlite/sqlite 2.1.0 update DRAFT RFC: androidx.sqlite/sqlite 2.x.x update Jan 4, 2023
@brody2consult brody2consult marked this pull request as draft January 4, 2023 18:59
@brody2consult brody2consult changed the title DRAFT RFC: androidx.sqlite/sqlite 2.x.x update androidx.sqlite/sqlite 2.2.0 update Jan 8, 2023
@brody2consult brody2consult marked this pull request as ready for review January 8, 2023 18:49
@brody2consult brody2consult marked this pull request as draft January 8, 2023 19:36
@brody2consult brody2consult changed the title androidx.sqlite/sqlite 2.2.0 update update androidx.sqlite/sqlite -> 2.1.0 Jan 8, 2023
@brody2consult brody2consult marked this pull request as ready for review January 8, 2023 19:47
@brody2consult
Copy link
Copy Markdown
Author

I hope we can consider getting this one updated to 2.1.0 or 2.2.0. I think 2.2.0 would be ideal but it seems to require Android SDK 31 update.

@developernotes
Copy link
Copy Markdown
Member

Hi @brodybits,

This is merged into master, thanks!

@brody2consult brody2consult deleted the patch-1 branch January 10, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants