Skip to content

ROX-32714: Update view tests to work with FlattenImageData#19844

Open
charmik-redhat wants to merge 1 commit intomasterfrom
ROX-32714/fix-view-tests
Open

ROX-32714: Update view tests to work with FlattenImageData#19844
charmik-redhat wants to merge 1 commit intomasterfrom
ROX-32714/fix-view-tests

Conversation

@charmik-redhat
Copy link
Copy Markdown
Contributor

Description

Updates view tests

User-facing documentation

  • CHANGELOG update is not needed
  • documentation is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Ran tests with and without the flag enabled

@charmik-redhat charmik-redhat force-pushed the ROX-32714/fix-view-tests branch from c2db61a to 750648a Compare April 6, 2026 18:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🚀 Build Images Ready

Images are ready for commit 750648a. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-568-g750648a4ac

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.60%. Comparing base (065e233) to head (750648a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/fixtures/image/reader.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19844      +/-   ##
==========================================
- Coverage   49.60%   49.60%   -0.01%     
==========================================
  Files        2763     2763              
  Lines      208339   208349      +10     
==========================================
+ Hits       103342   103346       +4     
- Misses      97331    97345      +14     
+ Partials     7666     7658       -8     
Flag Coverage Δ
go-unit-tests 49.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

@charmik-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests 750648a link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant