Skip to content

fix(testutils): Add missing env var name to RoxPassword error message #19857

Merged
guzalv merged 1 commit intomasterfrom
gualvare/fix-compliance-e2e-err-msg
Apr 7, 2026
Merged

fix(testutils): Add missing env var name to RoxPassword error message #19857
guzalv merged 1 commit intomasterfrom
gualvare/fix-compliance-e2e-err-msg

Conversation

@guzalv
Copy link
Copy Markdown
Contributor

@guzalv guzalv commented Apr 7, 2026

Description

Before:

Messages:       no password set via %s, and could not read password file

After:

Messages:       no password set via ROX_ADMIN_PASSWORD, and could not read password file

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@guzalv guzalv changed the title fix(compliance): Show missing env var name in error message fix(test): Show missing env var name in error message Apr 7, 2026
@guzalv guzalv changed the title fix(test): Show missing env var name in error message fix(testutils): Add missing env var name to RoxPassword error message Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🚀 Build Images Ready

Images are ready for commit 17bf2cb. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-578-g17bf2cb747

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.60%. Comparing base (7678bbc) to head (47e4e72).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19857   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files        2763     2763           
  Lines      208339   208339           
=======================================
  Hits       103342   103342           
  Misses      97332    97332           
  Partials     7665     7665           
Flag Coverage Δ
go-unit-tests 49.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guzalv guzalv marked this pull request as ready for review April 7, 2026 09:51
@guzalv guzalv requested a review from a team April 7, 2026 09:52
@guzalv guzalv enabled auto-merge (squash) April 7, 2026 12:05
@guzalv guzalv merged commit 17bf2cb into master Apr 7, 2026
116 checks passed
@guzalv guzalv deleted the gualvare/fix-compliance-e2e-err-msg branch April 7, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants