fix(github): nil-check token source to avoid panic when no token configured#8298
Open
loispostula wants to merge 1 commit intoupdatecli:mainfrom
Open
fix(github): nil-check token source to avoid panic when no token configured#8298loispostula wants to merge 1 commit intoupdatecli:mainfrom
loispostula wants to merge 1 commit intoupdatecli:mainfrom
Conversation
…igured GetTokenSourceFromConfig/Env legitimately return a nil oauth2.TokenSource when nothing is configured. GetAccessToken called Token() on that nil source, panicking deep inside Clone instead of returning a usable error. Fixes updatecli#8297 Signed-off-by: Loïs Postula <lois@postu.la>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8297
GetTokenSourceFromConfig/GetTokenSourceFromEnvlegitimately return aniloauth2.TokenSourcewhen nothing is configured.GetAccessTokencalledToken()on that nil source, panicking deep insideCloneinstead of returning a usable error.Test
To test this pull request, you can run the following commands:
A regression test
TestGetAccessToken_NilTokenSourcewas added assertingGetAccessToken(nil)returns an error without panicking.Additional Information
Checklist
Tradeoff
The error is still surfaced inside
Clonerather than at SCM init time. Surfacing it earlier would be a larger change touching the GitHub SCM init path; this PR is the minimal fix to stop the panic.Potential improvement
Detect "no token configured" at GitHub SCM init time and fail fast with an actionable message before reaching
Clone.