Miscellaneous zig std api breaking fix#1620
Merged
llogick merged 6 commits intozigtools:masterfrom Nov 26, 2023
jimying:no-trait
Merged
Miscellaneous zig std api breaking fix#1620llogick merged 6 commits intozigtools:masterfrom jimying:no-trait
llogick merged 6 commits intozigtools:masterfrom
jimying:no-trait
Conversation
ps: this change need set minimum zig build version to 0.12.0-dev.1686+d5e21a4f1
nektro
approved these changes
Nov 23, 2023
jimying
changed the title
llogick
reviewed
Nov 24, 2023
Contributor
llogick
left a comment
llogick
left a comment
There was a problem hiding this comment.
Make sure to test that it builds with -Doptimize=ReleaseSafe
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
- Coverage 73.79% 73.77% -0.02%
==========================================
Files 33 33
Lines 8974 8981 +7
==========================================
+ Hits 6622 6626 +4
- Misses 2352 2355 +3 ☔ View full report in Codecov by Sentry. |
Contributor
|
Any Windows users willing to do a PR? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix zig std api breaking list:
ziglang/zig@d5e21a4
std: remove meta.trait ziglang/zig#18061
std.fs: split
DirintoIterableDirziglang/zig#12060rework std.atomic ziglang/zig#18085