Skip to content

Refactor HTML response code#974

Merged
theacodes merged 3 commits intoGoogleCloudPlatform:masterfrom
dbarella:patch-1
Jun 5, 2017
Merged

Refactor HTML response code#974
theacodes merged 3 commits intoGoogleCloudPlatform:masterfrom
dbarella:patch-1

Conversation

@dbarella
Copy link
Copy Markdown
Contributor

@dbarella dbarella commented Jun 2, 2017

Make the response writing more readable by pulling the HTML into a format string.

Make the response writing more readable by pulling the HTML into a format string.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2017
@theacodes
Copy link
Copy Markdown
Contributor

One of our guiding principles for samples internally is to Prefer less indirection. This change introduces indirection. Is there any way you can improve the readability in a way that you like without introducing indirection?

Reduce some of the indirection.
@dbarella
Copy link
Copy Markdown
Contributor Author

dbarella commented Jun 3, 2017

Sure, check this version out!

@theacodes theacodes merged commit a359e09 into GoogleCloudPlatform:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants