Skip to content

Refactor HTML response code #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theacodes merged 3 commits into from
Jun 5, 2017
Merged

Refactor HTML response code #974

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b89f1
Refactor HTML response code
dbarella Jun 2, 2017
6bb4c27
Inline the response template string
dbarella Jun 3, 2017
ad0b2ef
Fix lint error
dbarella Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions appengine/standard/ndb/overview/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

# [START all]
import cgi
import textwrap
import urllib

from google.appengine.ext import ndb
Expand All @@ -48,23 +49,37 @@ def get(self):
guestbook_name = self.request.get('guestbook_name')
ancestor_key = ndb.Key("Book", guestbook_name or "*notitle*")
greetings = Greeting.query_book(ancestor_key).fetch(20)

for greeting in greetings:
self.response.out.write('<blockquote>%s</blockquote>' %
cgi.escape(greeting.content))
# [END query]

self.response.out.write("""
<form action="/sign?%s" method="post">
<div><textarea name="content" rows="3" cols="60"></textarea></div>
<div><input type="submit" value="Sign Guestbook"></div>
</form>
<hr>
<form>Guestbook name: <input value="%s" name="guestbook_name">
<input type="submit" value="switch"></form>
</body>
</html>""" % (urllib.urlencode({'guestbook_name': guestbook_name}),
cgi.escape(guestbook_name)))
greeting_blockquotes = []
for greeting in greetings:
greeting_blockquotes.append(
'<blockquote>%s</blockquote>' % cgi.escape(greeting.content))

self.response.out.write(textwrap.dedent("""\
<html>
<body>
{blockquotes}
<form action="/sign?{sign}" method="post">
<div>
<textarea name="content" rows="3" cols="60">
</textarea>
</div>
<div>
<input type="submit" value="Sign Guestbook">
</div>
</form>
<hr>
<form>
Guestbook name:
<input value="{guestbook_name}" name="guestbook_name">
<input type="submit" value="switch">
</form>
</body>
</html>""").format(
blockquotes='\n'.join(greeting_blockquotes),
sign=urllib.urlencode({'guestbook_name': guestbook_name}),
guestbook_name=cgi.escape(guestbook_name)))


# [START submit]
Expand Down