Add global helm deploy flags

[franklinkim]

I added the option to add global arguments to helm deploy, similar to kubectl.

deploy:
  helm:
    flags:
      global: [""]

This allows you to add any of:

Flags:
      --debug                           enable verbose output
  -h, --help                            help for helm
      --home string                     location of your Helm config. Overrides $HELM_HOME (default "~/.helm")
      --host string                     address of Tiller. Overrides $HELM_HOST
      --kube-context string             name of the kubeconfig context to use
      --kubeconfig string               absolute path to the kubeconfig file to use
      --tiller-connection-timeout int   the duration (in seconds) Helm will wait to establish a connection to tiller (default 300)
      --tiller-namespace string         namespace of Tiller (default "kube-system")

This should resolve #1183, #785 and also #529

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[codecov-io]

Codecov Report

Merging #1284 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage    44.3%   44.31%   +0.01%     
==========================================
  Files         104      104              
  Lines        4623     4624       +1     
==========================================
+ Hits         2048     2049       +1     
  Misses       2366     2366              
  Partials      209      209

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm.go	65.72% <100%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e9cbd...5300e94. Read the comment docs.

[nkubala]

Hey @franklinkim, thanks for the PR! Looks like there's an issue with your CLA, can you verify the commits are signed with the correct email address and comment "I signed it!" when you think it's ready?

[franklinkim]

I signed it!

[yeahphil]

@franklinkim this PR looks good, and I'd like to help it get merged if possible (it resolves #785, which I need, and seems like something a lot of other folks should want!)

Looks like their automated CLA machinery is still not picking up that you've signed it -- have you signed with the email address on your commits? (kevin@franklinkim.de)

[franklinkim]

I signed it!

[googlebot]

CLAs look good, thanks!

[franklinkim]

@yeahphil your right, added a different one last time... my bad. thx

[yeahphil]

🙌 thank you!

[nkubala]

Thanks for dealing with the CLA shenanigans @franklinkim. This LGTM but I don't wanna merge until CI passes, and I'm not really sure what's going on with Kokoro today....let me take a look and see if I can restart the job

[yeahphil]

Looking into this a bit further by applying the PR and trying to use it, it doesn't actually resolve #785 (see issue for details). Still seems useful and should allow --tiller-namespace, but that issue will need a different solution

[tjerkw]

I like this. However i really would like to have flags for "helm install" or "helm upgrade".

If we merge this there will be a bit of a mix of helm flags, and custom yaml fields for helm.
For example "recreate pods" is such a flag that could be a normal helm flag.

	if !isInstalled {
		args = append(args, "install", "--name", releaseName)
	} else {
		args = append(args, "upgrade", releaseName)
		if r.RecreatePods {
			args = append(args, "--recreate-pods")
		}
}

So the "if r.RecreatePods" could be a helm flag.

I would like the following things also to be usable. And settable per "helm install" or "helm upgrade" command.

We could merge this first, and then improve upon that?

[tjerkw]

I created a pull request with my suggestions:
#1673

[priyawadhwa]

Hey @franklinkim, can this be closed now that #1673 has merged?

[franklinkim]

@priyawadhwa yes, that should solve it