Helm flags for Global, Install and Upgrade helm commands

[tjerkw]

This solves the following outstanding pull requests (they can all be closed):
#1284 #1506 #1507 #1445 #1499

It allows configuring flags to helm, for

• Global helm flags (Similar to Add global helm deploy flags #1284)
• "helm install" flags
• "helm upgrade" flags

The code is similar to the code in kustomize, and kubectl. They all have the option to add flags to the deploy commands.

This also makes skaffold easier to use if helm comes with new flags, it will "just work". Since the flags are free text. Just add them, and run 👍

Btw: The flags are set on the top level "HelmDeploy" struct. Not in the "HelmRelease" section in the yaml file.

This is because a "Global" flags list doesn't make sense per release. Then its not global anymore.

Custom flags to "helm install/upgrade" do make sense per release. But most of the time you probably want to keep them similar. Thats why i didn't set the flag on the HelmRelease struct.

Also: The flags clash a bit with the "Wait" and "RecreatePods" and "Namespace" fields in HelmRelease. However if you use both helm would complain and not run. So we're fine there.

[priyawadhwa]

Thanks for your contribution! Left some comments.

[codecov-io]

Codecov Report

Merging #1673 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
+ Coverage   46.52%   46.55%   +0.02%     
==========================================
  Files         125      125              
  Lines        5661     5664       +3     
==========================================
+ Hits         2634     2637       +3     
  Misses       2754     2754              
  Partials      273      273

Impacted Files	Coverage Δ
pkg/skaffold/deploy/helm.go	61.96% <100%> (+0.49%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f46a7...3c34f41. Read the comment docs.

[tjerkw]

This is now ready to go. Thanks for the comments @priyawadhwa

[priyawadhwa]

One more fix :)

[tjerkw]

Is this ok to go?

[priyawadhwa]

@tjerkw I think you just need to rebase, and then I can merge this!

[priyawadhwa]

Looks like travis failed --

--- FAIL: TestSchemas (0.26s)
	main_test.go:30: json schema files are not up to date.
           Please run `make generate-schemas` and commit the changes.

If you run that command and commit I think that should fix it!

[tjerkw]

Done. Forgot about it.

[priyawadhwa]

LGTM, thanks so much for your contribution!