Skip to content

feat(deploy): support timeout flag for helm#1445

Closed
moustafab wants to merge 1 commit intoGoogleContainerTools:masterfrom
VibrentHealth:master
Closed

feat(deploy): support timeout flag for helm#1445
moustafab wants to merge 1 commit intoGoogleContainerTools:masterfrom
VibrentHealth:master

Conversation

@moustafab
Copy link
Copy Markdown

I was playing with this and had trouble getting it to work with some large umbrella charts. The default timeout is 5 minutes with helm (300 seconds) and this provides you with the built-in helm way of changing that. This replaces #1443 I needed to open the PR from my org. Sorry!

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@moustafab
Copy link
Copy Markdown
Author

signed it

@tjerkw
Copy link
Copy Markdown

tjerkw commented Jan 22, 2019

The linter failed, please fix:

int64 yaml:"timeout,omitempty" pkg/skaffold/schema/latest/config.go:189:18: struct of size 168 bytes could be of size 160 bytes (maligned) type HelmRelease struct { ^ FAILED hack/linter.sh

@tjerkw
Copy link
Copy Markdown

tjerkw commented Jan 22, 2019

I fixed it in a new PR #1506

@tjerkw
Copy link
Copy Markdown

tjerkw commented Jan 22, 2019

I would recommend closing this issue

@moustafab
Copy link
Copy Markdown
Author

Closing in favor of #1507

@tjerkw
Copy link
Copy Markdown

tjerkw commented Feb 19, 2019

FYI: #1507 was closed in favor to the more general solution of passing flags:
#1673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants