Merged
Conversation
prary
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
balopat
previously requested changes
Jun 19, 2019
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
Thank you for opening this!
Do you mind adding a test?
After a test + fixing travis this LGTM.
Contributor
Author
|
@balopat fixed travis error. |
Codecov Report
|
tejal29
approved these changes
Jun 21, 2019
balopat
added
docs-modifications
|
Please visit http://35.236.79.231:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
approved these changes
Jul 9, 2019
Contributor
|
Hey @prary , please run |
tejal29
added
the
docs-modifications
|
Please visit http://35.235.66.89:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tejal29
force-pushed
the
kaniko_proxy
branch
2 times, most recently
from
27cf723 to
f26274b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of PR #2064 Setting proxy for Kaniko Pod