Skip to content

Freeze v1beta12 and prepare v1beta13#2430

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:freeze-v1beta12
Jul 9, 2019
Merged

Freeze v1beta12 and prepare v1beta13#2430
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:freeze-v1beta12

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Jul 8, 2019

A new version is required by #2188

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2019

Codecov Report

Merging #2430 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/v1beta11/upgrade.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta12/upgrade.go 100% <100%> (ø)
pkg/skaffold/schema/v1beta12/config.go 100% <100%> (ø)

balopat
balopat previously requested changes Jul 8, 2019
Copy link
Copy Markdown
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold off until we have an lgtm on that PR.

@tejal29
Copy link
Copy Markdown
Contributor

tejal29 commented Jul 9, 2019

I have another approved PR #2283 which is waiting on config freeze.

@tejal29 tejal29 dismissed balopat’s stale review July 9, 2019 23:53

need to merge #2283

@tejal29 tejal29 merged commit c8ea424 into GoogleContainerTools:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants