Merged
Conversation
More documentation. Signed-off-by: David Gageot <david@gageot.net>
dgageot
added
the
docs-modifications
|
Please visit http://35.236.53.50:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
dgageot
added
the
priority/p0
balopat
approved these changes
Nov 7, 2019
briandealwis
reviewed
Nov 7, 2019
| --- | ||
|
|
||
| [Buildpacks]((https://buildpacks.io/)) enable building language-based containers from source code, without the need for a Dockerfile. | ||
| [Cloud Native Buildpacks](https://buildpacks.io/) enable building language-based |
Member
There was a problem hiding this comment.
"language-based" sounds odd.
Suggested change
| [Cloud Native Buildpacks](https://buildpacks.io/) enable building language-based | |
| [Cloud Native Buildpacks](https://buildpacks.io/) enable building image |
Comment on lines
+11
to
+13
| Skaffold supports building with Buildpacks natively, without installing | ||
| additional software. However, Buildpacks require a local Docker daemon | ||
| to be used. |
Member
There was a problem hiding this comment.
Docker is additional software :-)
Skafold supports building with Cloud Native Buildpacks, a source to image solution that requires only a local Docker installation.
?
Comment on lines
+15
to
+17
| Once all the necessary data is present, Skaffold will build inside a container, | ||
| with the local Docker daemon, with ther builder image specified in `builder`, | ||
| in the `buildpack` config. |
Member
There was a problem hiding this comment.
What's the necessary data? Too many commas.
Skaffold performs the build inside a container using the builder specified in the buildpack config.
| To use Buildpacks, add a `buildpack` field to each artifact you specify in the | ||
| `artifacts` part of the `build` section. `context` should be a path to | ||
| your source. | ||
| your sources. |
Member
There was a problem hiding this comment.
Since a buildpack will build a single image, I think singular is better here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More documentation.
Signed-off-by: David Gageot david@gageot.net