[doc] debug does not work with buildpack builder and maybe custom builder images too#3204
Merged
balopat merged 2 commits intoGoogleContainerTools:masterfrom Nov 7, 2019
Merged
Conversation
briandealwis
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
briandealwis
force-pushed
the
debuglimitations
branch
from
b0b7ec6 to
242261d
Compare
Member
Author
|
I started to add explicit doc to the custom builder but realized that it applied equally to the docker and jib builders too. Those builds can be altered to fit whereas Buildpacks can not. |
balopat
reviewed
Nov 7, 2019
balopat
reviewed
Nov 7, 2019
balopat
reviewed
Nov 7, 2019
balopat
reviewed
Nov 7, 2019
balopat
reviewed
Nov 7, 2019
balopat
reviewed
Nov 7, 2019
|
|
||
| `skaffold debug` has some limitations. | ||
|
|
||
| ### Entrypoints using Launchers or Scripts |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Entrypoints using Launchers or Scripts | |
| ### Unsupported container entrypoints |
maybe? and then we can link to this from the other doc
balopat
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skaffold debugrequires being able to examine and alter an image's entrypoint, and won't work with images using a launcher or some startup script. Add note todebugdoc and explicitly call this out on the Buildpacks builder too. Also incorporates minor tweaks to #3199 too.