Skip to content

Fix skaffold credits#3436

Merged
balopat merged 3 commits intoGoogleContainerTools:masterfrom
dgageot:fix-credits
Jan 3, 2020
Merged

Fix skaffold credits#3436
balopat merged 3 commits intoGoogleContainerTools:masterfrom
dgageot:fix-credits

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Dec 24, 2019

  • Add integration test
  • Fix the code

Fixes #3428

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2019

Codecov Report

Merging #3436 into master will increase coverage by 0.04%.
The diff coverage is 57.14%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/schema/print.go 80% <100%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
pkg/skaffold/util/tar.go 57.47% <0%> (+4.59%) ⬆️

Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Generate a single statik.go file that embeds
both credits and schemas.

Fixes GoogleContainerTools#3428
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 24, 2019
@dgageot dgageot marked this pull request as ready for review December 24, 2019 10:34
@dgageot dgageot mentioned this pull request Dec 24, 2019
@balopat balopat merged commit d5b16c9 into GoogleContainerTools:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skaffold credits produces incorrect output

3 participants