Conversation
Codecov Report
|
Fixes GoogleContainerTools#3443 Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
simpler-credits
branch
from
8377d08 to
4391c35
Compare
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
I don't agree with this change, I think it's important to use the go-licenses tool. See my comment.
| ${LICENSES} save "github.com/GoogleContainerTools/skaffold/cmd/skaffold" --save_path="${TMP_DIR}/skaffold-credits" | ||
| # Copy licenses | ||
| pushd vendor | ||
| LICENSES=$(find . \( -type f -name 'LICENSE*' -or -name 'COPYING*' -or -name 'NOTICE*' \)) |
There was a problem hiding this comment.
Integrating with licenses is important and was intentional, so that we don't have to maintain this logic.
This line does not cover the logic of licenses. For example there is a requirement that Mozilla Public License licenses need to include the source as well.
The package moved to https://github.com/google/go-licenses and we will have to switch over to that. But I'd rather use that then this logic. This gives us flexibility and maintainability on the long run as well, e.g. if we switch over to downloading go modules instead of vendor directory, the library will work just as well, while this line will break.
There was a problem hiding this comment.
OK. Makes sense. I tried https://github.com/google/go-license and it's slow as hell now. We need to find a way to make it faster or to make it not run each time we make install
There was a problem hiding this comment.
What do you mean slow as hell?
3 participants
Requires #3436 to be merged first
Fixes #3443