Update CLI tools in docker image#3527
Update CLI tools in docker image#3527nicknovitski wants to merge 1 commit intoGoogleContainerTools:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
994cd40 to
46286de
Compare
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Is the kokoro check supposed to finish in finite time? |
deploy/skaffold/Dockerfile
Outdated
| # Download kubectl | ||
| FROM alpine:3.10 as download-kubectl | ||
| ENV KUBECTL_VERSION v1.12.8 | ||
| ENV KUBECTL_VERSION v1.17.1 |
There was a problem hiding this comment.
That makes sense. How about 1.14?
It's also possible to install kubectl as a google cloud sdk component, which will provide a consistent version without needing it to be specified separately from the cloud sdk version. Currently the sdk provides version 1.14.x of kubectl. It also includes binaries like kubectl.1.1{3,4,5}, but I don't see a way for skaffold to use those.
46286de to
0846b84
Compare
Helm purposely not updated due to breaking integration tests. kubectl purposely only updated two major versions, to retain compatibility with more clusters.
0846b84 to
771fcc5
Compare
|
Ah, #3433 was just merged, which puts these deps into a separate image that has to be manually built, pushed, and referenced. I can't push the image, so I can't really complete this contribution. :/ |
|
If that’s fine by you, I can cherry pick your commits and push a new PR.
…On Tue 21 Jan 2020 at 19:08 Nick Novitski ***@***.***> wrote:
Ah, #3433 <#3433>
was just merged, which puts these deps into a separate image that has to be
manually built, pushed, and referenced.
# This base image has to be updated manually after running `make build_deps`
FROM gcr.io/k8s-skaffold/build_deps:6f7f8095b663b0c9c18873855f55fee20aa06a7e
I can't push the image, so I can't really complete this contribution. :/
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#3527?email_source=notifications&email_token=AABFPF3BOX53UIFTEE77LFTQ642YPA5CNFSM4KIOHLN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQWDDA#issuecomment-576807308>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFPF23LN5LRQLZFMWCGK3Q642YPANCNFSM4KIOHLNQ>
.
|
|
Thank you, that would be fine with me. |
|
closing in favor of #3553 |
|
@nicknovitski do you mind writing a comment on the #3553 PR to confirm your consent on @dgageot cherry picking your commits into that PR? |
Hopefully this is a fairly self-explanatory change.