Skip to content

Update CLI tools in docker image#3527

Closed
nicknovitski wants to merge 1 commit intoGoogleContainerTools:masterfrom
nicknovitski:update-cli-tools-in-docker-image
Closed

Update CLI tools in docker image#3527
nicknovitski wants to merge 1 commit intoGoogleContainerTools:masterfrom
nicknovitski:update-cli-tools-in-docker-image

Conversation

@nicknovitski
Copy link
Copy Markdown
Contributor

Hopefully this is a fairly self-explanatory change.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2020

Codecov Report

Merging #3527 into master will not change coverage.
The diff coverage is n/a.

@nicknovitski nicknovitski force-pushed the update-cli-tools-in-docker-image branch 2 times, most recently from 994cd40 to 46286de Compare January 18, 2020 02:23
@nicknovitski
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@nicknovitski
Copy link
Copy Markdown
Contributor Author

Is the kokoro check supposed to finish in finite time?

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jan 20, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 20, 2020
# Download kubectl
FROM alpine:3.10 as download-kubectl
ENV KUBECTL_VERSION v1.12.8
ENV KUBECTL_VERSION v1.17.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to jump directly to the latest version of kubectl. Only a few users will have this version installed and it's not guaranteed to be compatible with every older version of k8s. ping @nkubala @balopat

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. How about 1.14?

It's also possible to install kubectl as a google cloud sdk component, which will provide a consistent version without needing it to be specified separately from the cloud sdk version. Currently the sdk provides version 1.14.x of kubectl. It also includes binaries like kubectl.1.1{3,4,5}, but I don't see a way for skaffold to use those.

@nicknovitski nicknovitski force-pushed the update-cli-tools-in-docker-image branch from 46286de to 0846b84 Compare January 21, 2020 17:48
Helm purposely not updated due to breaking integration tests.

kubectl purposely only updated two major versions, to retain compatibility with
more clusters.
@nicknovitski nicknovitski force-pushed the update-cli-tools-in-docker-image branch from 0846b84 to 771fcc5 Compare January 21, 2020 17:57
@nicknovitski
Copy link
Copy Markdown
Contributor Author

Ah, #3433 was just merged, which puts these deps into a separate image that has to be manually built, pushed, and referenced.

# This base image has to be updated manually after running `make build_deps`
FROM gcr.io/k8s-skaffold/build_deps:6f7f8095b663b0c9c18873855f55fee20aa06a7e

I can't push the image, so I can't really complete this contribution. :/

@dgageot
Copy link
Copy Markdown
Contributor

dgageot commented Jan 21, 2020 via email

@nicknovitski
Copy link
Copy Markdown
Contributor Author

Thank you, that would be fine with me.

@dgageot dgageot self-assigned this Jan 22, 2020
@dgageot dgageot mentioned this pull request Jan 22, 2020
@dgageot
Copy link
Copy Markdown
Contributor

dgageot commented Jan 22, 2020

closing in favor of #3553

@dgageot dgageot closed this Jan 22, 2020
@balopat
Copy link
Copy Markdown
Contributor

balopat commented Jan 24, 2020

@nicknovitski do you mind writing a comment on the #3553 PR to confirm your consent on @dgageot cherry picking your commits into that PR?

@nicknovitski nicknovitski deleted the update-cli-tools-in-docker-image branch January 24, 2020 19:03
@nicknovitski nicknovitski restored the update-cli-tools-in-docker-image branch January 24, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants