Skip to content

Build skaffold-builder image from a pre-pushed base#3433

Merged
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:faster-skaffold-builder
Jan 21, 2020
Merged

Build skaffold-builder image from a pre-pushed base#3433
nkubala merged 1 commit intoGoogleContainerTools:masterfrom
dgageot:faster-skaffold-builder

Conversation

@dgageot
Copy link
Copy Markdown
Contributor

@dgageot dgageot commented Dec 23, 2019

This is meant to accelerate the integration tests: instead of installing all the cli tools on each build, we have a pre-pushed base image that contains all those tools.

What I've done is pre-built the gcr.io/k8s-skaffold/build_deps image and referenced it by digest.

Question: How can we do that in a more automatized way?

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot force-pushed the faster-skaffold-builder branch from 87e2eb6 to e169c38 Compare December 23, 2019 17:31
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2019 •
edited
Loading

Codecov Report

Merging #3433 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@balopat
Copy link
Copy Markdown
Contributor

balopat commented Jan 6, 2020

This is meant to accelerate the integration tests: instead of installing all the cli tools on each build, we have a pre-pushed base image that contains all those tools.

What I've done is pre-built the gcr.io/k8s-skaffold/build_deps image and referenced it by digest.

Question: How can we do that in a more automatized way?

How about using artifact caching and use skaffold itself to build & push the build_deps? That will lose a couple of seconds on each build but not full rebuilds of the deps.

balopat
balopat reviewed Jan 6, 2020
View reviewed changes
@dgageot dgageot force-pushed the faster-skaffold-builder branch from e169c38 to 8800bb0 Compare January 8, 2020 09:58
@nkubala
Copy link
Copy Markdown
Contributor

nkubala commented Jan 8, 2020

how will we know when we need to rebuild the base image here? I guess it's not really a huge deal cause we're probably not updating build tools very often.

nkubala
nkubala reviewed Jan 8, 2020
View reviewed changes
@dgageot dgageot force-pushed the faster-skaffold-builder branch 2 times, most recently from d790bff to 4b03792 Compare January 10, 2020 12:37
@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented Jan 10, 2020

@nkubala I added a script that updates deploy/skaffold/Dockerfile. Also make checks now verifies that this file is up to date.

@dgageot dgageot force-pushed the faster-skaffold-builder branch 5 times, most recently from c2676ca to 55ec3e4 Compare January 17, 2020 08:35
@dgageot
Copy link
Copy Markdown
Contributor Author

dgageot commented Jan 17, 2020

Hey @nkubala can you TAL at this one?

@dgageot
Build skaffold-builder image from a pre-pushed base
79f3fa8 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot force-pushed the faster-skaffold-builder branch from 55ec3e4 to 79f3fa8 Compare January 20, 2020 07:23
@nkubala nkubala merged commit d11a906 into GoogleContainerTools:master Jan 21, 2020
@nicknovitski nicknovitski mentioned this pull request Jan 21, 2020
Closed
balopat added a commit to balopat/skaffold that referenced this pull request Jan 31, 2020
@balopat
Revert "Merge pull request GoogleContainerTools#3433 from dgageot/fas…
841ed36 
…ter-skaffold-builder"

This reverts commit d11a906, reversing
changes made to 29a6f60.
tejal29 added a commit that referenced this pull request Jan 31, 2020
@tejal29
Merge pull request #3626 from balopat/revert_docker_image_changes
e609b6f 
Revert "Merge pull request #3433 from dgageot/faster-skaffold-builder"
dgageot added a commit to dgageot/skaffold that referenced this pull request Feb 3, 2020
@dgageot
Restore pull request GoogleContainerTools#3433 from dgageot/faster-sk…
ebc9b7b 
…affold-builder

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this pull request Feb 3, 2020
Merged
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this pull request Feb 3, 2020
@balopat
Revert "Merge pull request GoogleContainerTools#3433 from dgageot/fas…
270492a 
…ter-skaffold-builder"

This reverts commit d11a906, reversing
changes made to 29a6f60.
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this pull request Feb 3, 2020
@balopat
Revert "Merge pull request GoogleContainerTools#3433 from dgageot/fas…
39cfbdd 
…ter-skaffold-builder"

This reverts commit d11a906, reversing
changes made to 29a6f60.
dgageot added a commit to dgageot/skaffold that referenced this pull request Feb 4, 2020
@dgageot
Restore pull request GoogleContainerTools#3433 from dgageot/faster-sk…
284c6bd 
…affold-builder

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/skaffold that referenced this pull request Feb 4, 2020
@dgageot
Restore pull request GoogleContainerTools#3433 from dgageot/faster-sk…
a485ee7 
…affold-builder

Signed-off-by: David Gageot <david@gageot.net>
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this pull request Feb 8, 2020
@dgageot
Restore pull request GoogleContainerTools#3433 from dgageot/faster-sk…
a74f742 
…affold-builder

Signed-off-by: David Gageot <david@gageot.net>
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this pull request Feb 8, 2020
@dgageot
Restore pull request GoogleContainerTools#3433 from dgageot/faster-sk…
6bf21eb 
…affold-builder

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tejal29 tejal29 Awaiting requested review from tejal29

2 more reviewers

@balopat balopat balopat left review comments

@nkubala nkubala nkubala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nkubala nkubala

Labels

cla: yes size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgageot @balopat @nkubala @googlebot