Prevent nil pointer dereference#3594
Closed
dgageot wants to merge 1 commit intoGoogleContainerTools:masterfrom
Closed
Prevent nil pointer dereference#3594dgageot wants to merge 1 commit intoGoogleContainerTools:masterfrom
dgageot wants to merge 1 commit intoGoogleContainerTools:masterfrom
Conversation
Signed-off-by: David Gageot <david@gageot.net>
balopat
suggested changes
Jan 27, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
I think the NewGcloudAuthenticator error handling (the lack of it) is adding to the problem. In L87 we might fail with an error, then go to defaultkeychain which then returns nil ...
Let's reproduce the issue and understand it deeper.
Codecov Report
|
Contributor
Author
|
@balopat yes, you're right. |
Contributor
Author
|
Closing in favour of #3597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how this can happen but this has happened.
I will try to reproduce and add tests around that code.
Signed-off-by: David Gageot david@gageot.net