Fix nil pointer dereference when no account is set on gcloud. by dgageot · Pull Request #3597 · GoogleContainerTools/skaffold

dgageot · 2020-01-28T08:56:47Z

And add unit tests

codecov · 2020-01-28T09:04:37Z

Codecov Report

Merging #3597 into master will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted Files	Coverage Δ
pkg/skaffold/docker/authenticators.go	`86.66% <66.66%> (+21.14%)`	⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go	`65.85% <0%> (-2.44%)`	⬇️

Fixes GoogleContainerTools#3596 And add unit tests

dgageot requested review from balopat, nkubala and tejal29 as code owners January 28, 2020 08:56

googlebot added the cla: yes label Jan 28, 2020

pull-request-size bot added the size/L label Jan 28, 2020

dgageot mentioned this pull request Jan 28, 2020

Prevent nil pointer dereference #3594

Closed

Fix nil pointer dereference when no account is set on gcloud.

550b8c6

Fixes GoogleContainerTools#3596 And add unit tests

dgageot force-pushed the fix-3596 branch from b92e6eb to 550b8c6 Compare January 28, 2020 10:23

balopat approved these changes Jan 28, 2020

View reviewed changes

dgageot merged commit 25fb8fc into GoogleContainerTools:master Jan 28, 2020