Skip to content

Revert "Merge pull request #3433 from dgageot/faster-skaffold-builder"#3626

Merged
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
balopat:revert_docker_image_changes
Jan 31, 2020
Merged

Revert "Merge pull request #3433 from dgageot/faster-skaffold-builder"#3626
tejal29 merged 2 commits intoGoogleContainerTools:masterfrom
balopat:revert_docker_image_changes

Conversation

@balopat
Copy link
Copy Markdown
Contributor

@balopat balopat commented Jan 31, 2020 •
edited
Loading

This reverts commit d11a906.

Fixes #3622.

@balopat
Revert "Merge pull request GoogleContainerTools#3433 from dgageot/fas…
841ed36 
…ter-skaffold-builder"

This reverts commit d11a906, reversing
changes made to 29a6f60.
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #3626 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 70.54% <0%> (+3.1%) ⬆️
pkg/skaffold/build/buildpacks/lifecycle.go 71.42% <0%> (+4.76%) ⬆️
pkg/skaffold/update/update.go 58.06% <0%> (+22.58%) ⬆️

@tejal29 tejal29 merged commit e609b6f into GoogleContainerTools:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

1 more reviewer

@tejal29 tejal29 tejal29 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

skaffold docker image doesn't have skaffold binary

3 participants

@balopat @tejal29 @googlebot