Add helm3 support to the helm deployer#3738
Merged
nkubala merged 6 commits intoGoogleContainerTools:masterfrom Feb 27, 2020
Merged
Add helm3 support to the helm deployer#3738nkubala merged 6 commits intoGoogleContainerTools:masterfrom
nkubala merged 6 commits intoGoogleContainerTools:masterfrom
Conversation
tstromberg
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
Author
|
This PR assumes that #3743 is merged first to address packageChart quirks. |
nkubala
reviewed
Feb 27, 2020
Contributor
nkubala
left a comment
nkubala
left a comment
There was a problem hiding this comment.
a few nits but this looks great
tstromberg
changed the title
nkubala
approved these changes
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based almost entirely on @ktarplee 's work in #2900 - with some additional testing and refactoring to prepare for it's insertion.
Fixes #2142 #3438