Skip to content

helm chart packaging: improve errors, logic & testability#3743

Merged
nkubala merged 4 commits intoGoogleContainerTools:masterfrom
tstromberg:helm-cleanup2
Feb 27, 2020
Merged

helm chart packaging: improve errors, logic & testability#3743
nkubala merged 4 commits intoGoogleContainerTools:masterfrom
tstromberg:helm-cleanup2

Conversation

@tstromberg
Copy link
Copy Markdown

@tstromberg tstromberg commented Feb 27, 2020 •
edited
Loading

Cleaning up some technical debt encountered while adding helm3 support.

These unexpected behaviors were revealed by tests that I unexpectedly broke while working on #3738

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #3743 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
pkg/skaffold/deploy/helm.go 74.65% <100%> (-0.18%) ⬇️

@tstromberg tstromberg mentioned this pull request Feb 27, 2020
Merged
@tstromberg tstromberg changed the title helm packageChart: improve error messages, simplify logic helm packageChart: improve errors, logic & testability Feb 27, 2020
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 27, 2020
@tstromberg tstromberg changed the title helm packageChart: improve errors, logic & testability helm chart packaging: improve error msgs, logic & testability Feb 27, 2020
@tstromberg tstromberg changed the title helm chart packaging: improve error msgs, logic & testability helm chart packaging: improve errors, logic & testability Feb 27, 2020
@tstromberg
Copy link
Copy Markdown
Author

tstromberg commented Feb 27, 2020

kokoro build failure appears to be a flake:

--- FAIL: TestBuildKanikoInsecureRegistry (67.97s)
...
   INFO[0018] Pushing layer 34.69.100.214:5000/kaniko-insecure/cache:bd5ba88067551119d57eb4ced79318e89aed0d80f54293d05bbca165803ae85f to cache now
        error pushing image: failed to push to destination 34.69.100.214:5000/kaniko-insecure:v1.4.0-45-g3f1fe5c: Head http://34.69.100.214:5000/v2/kaniko-insecure/blobs/sha256:437381f67cba8baf2942ec60087a0339197802dc784b297391aa2182ef19fcbd: dial tcp 34.69.100.214:5000: connect: connection reset by peer
    panic.go:563: time="2020-02-27T17:26:01Z" level=fatal msg="build failed: building [kaniko-insecure]: waiting for pod to complete: condition error: pod already in terminal phase: Failed"

It seems like skaffold may not be trying to retry kaniko pushes :(

@nkubala nkubala merged commit befffb8 into GoogleContainerTools:master Feb 27, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@tejal29 tejal29 Awaiting requested review from tejal29

1 more reviewer

@nkubala nkubala nkubala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tstromberg @nkubala @googlebot