Use heroku/color for our colors#3757
Merged
dgageot merged 2 commits intoGoogleContainerTools:masterfrom Feb 29, 2020
Merged
Conversation
Codecov Report
|
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
revamp-colors
branch
from
2c28358 to
0295d87
Compare
Signed-off-by: David Gageot <david@gageot.net>
tejal29
reviewed
Feb 28, 2020
Contributor
tejal29
left a comment
tejal29
left a comment
There was a problem hiding this comment.
Did you forget to run go mod vendor ? I dont see any files added for the new dependency
Contributor
Author
|
@tejal29 It was already vendored for pack |
tejal29
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net