Ensure Windows console color enablement#4798
Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom Sep 21, 2020
Merged
Ensure Windows console color enablement#4798tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4798 +/- ##
==========================================
- Coverage 73.85% 71.83% -2.02%
==========================================
Files 347 347
Lines 13796 11873 -1923
==========================================
- Hits 10189 8529 -1660
+ Misses 2972 2725 -247
+ Partials 635 619 -16
Continue to review full report at Codecov.
|
tejal29
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4783
Description
Explicitly call
mattn/go-colorable'scolorable.EnableColorsStdout()to ensure Windows consoles are placed in a mode to decipher ANSI colour sequences.In #3757, we switched to using
heroku/colorto provide colour definitions. Althoughheroku/colorusesmattn/go-colorable, it doesn't callEnableColorsStdout(), and besides we are just usingheroku/color's colour definitions rather than their console output and io.Writer wrappers.Before:

After:
