Skip to content

Ensure Windows console color enablement#4798

Merged
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
briandealwis:win-color
Sep 21, 2020
Merged

Ensure Windows console color enablement#4798
tejal29 merged 1 commit intoGoogleContainerTools:masterfrom
briandealwis:win-color

Conversation

@briandealwis
Copy link
Copy Markdown
Member

Fixes: #4783

Description

Explicitly call mattn/go-colorable's colorable.EnableColorsStdout() to ensure Windows consoles are placed in a mode to decipher ANSI colour sequences.

In #3757, we switched to using heroku/color to provide colour definitions. Although heroku/color uses mattn/go-colorable, it doesn't call EnableColorsStdout(), and besides we are just using heroku/color's colour definitions rather than their console output and io.Writer wrappers.

Before:
Screen Shot 2020-09-17 at 3 20 55 PM

After:
Screen Shot 2020-09-17 at 3 20 17 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2020

Codecov Report

Merging #4798 into master will decrease coverage by 2.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4798      +/-   ##
==========================================
- Coverage   73.85%   71.83%   -2.02%     
==========================================
  Files         347      347              
  Lines       13796    11873    -1923     
==========================================
- Hits        10189     8529    -1660     
+ Misses       2972     2725     -247     
+ Partials      635      619      -16     
Impacted Files Coverage Δ
pkg/skaffold/color/formatter.go 90.00% <100.00%> (ø)
pkg/skaffold/trigger/workdir.go 20.00% <0.00%> (-13.34%) ⬇️
pkg/skaffold/initializer/analyze/directory.go 50.00% <0.00%> (-10.00%) ⬇️
pkg/diag/validator/resource.go 50.00% <0.00%> (-8.83%) ⬇️
pkg/skaffold/logfile/logfile.go 71.42% <0.00%> (-8.58%) ⬇️
pkg/skaffold/runner/debugging.go 66.66% <0.00%> (-8.34%) ⬇️
pkg/skaffold/deploy/resource/status.go 77.77% <0.00%> (-7.94%) ⬇️
pkg/skaffold/runner/portforwarder.go 22.22% <0.00%> (-7.78%) ⬇️
pkg/skaffold/runner/render.go 12.50% <0.00%> (-7.50%) ⬇️
pkg/skaffold/util/term.go 42.85% <0.00%> (-7.15%) ⬇️
... and 338 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10275c6...c16f585. Read the comment docs.

@briandealwis briandealwis added the kokoro:force-run forces a kokoro re-run on a PR label Sep 19, 2020
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 19, 2020
@tejal29 tejal29 merged commit b2f9ad4 into GoogleContainerTools:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outputting ANSI/VT100 escape sequences erroneously on Windows

4 participants