Refactored linting code and fixed issues#45
Open
olehermanse wants to merge 8 commits intocfengine:mainfrom
Open
Refactored linting code and fixed issues#45olehermanse wants to merge 8 commits intocfengine:mainfrom
olehermanse wants to merge 8 commits intocfengine:mainfrom
Conversation
olehermanse
force-pushed
the
rebase
branch
2 times, most recently
from
9d0c4bc to
c62d16a
Compare
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
… tests Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
olehermanse
force-pushed
the
rebase
branch
2 times, most recently
from
197c3de to
dd743a1
Compare
olehermanse
changed the title
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
looked at everything but the last big commit. Looks good so far!
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Almost a complete rewrite. It had a few issues: - Finding user defined bodies / bundles / promise types did not work when specifying file instead of folder. - Code paths for linting arg, vs file, vs folder, vs snippet were getting complicated and confusing. - Linting rules (node checks) and state changes were getting complicated. I wanted to simplify these before we add more rules. - Probably some other issues I cannot remember. Fixing the issues was not trivial, so I decided to refactor and fix at the same time. Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost a complete rewrite.
It had a few issues:
I wanted to simplify these before we add more rules.
Fixing the issues was not trivial, so I decided to refactor and fix at the same time.