fix(goods): handle errors in responseToReadable stream reader#1444
Open
daguimu wants to merge 1 commit intogoogle:mainfrom
Open
fix(goods): handle errors in responseToReadable stream reader#1444daguimu wants to merge 1 commit intogoogle:mainfrom
daguimu wants to merge 1 commit intogoogle:mainfrom
Conversation
deb84e4 to
acfc842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
fetch().pipe(), if the response body reader errors (e.g., due to network disconnection, aborted request, or corrupted stream), the async_readfunction inresponseToReadablethrows an unhandled promise rejection that can crash the Node.js process.Root Cause
The
_readmethod assigned inresponseToReadableis an async function, butreader.read()andBuffer.from()calls are not wrapped in a try/catch. Since Node.js stream internals call_readwithout awaiting or catching the returned promise, any rejection becomes unhandled.Fix
rs._readin a try/catch block inresponseToReadable(src/goods.ts)rs.destroy(err)to properly propagate the error through the stream, allowing downstream consumers to handle it gracefullyTests Added
_readwithrs.destroy(err)responseToReadable propagates reader errors to stream— creates a mock reader that rejects, verifies the error is propagated via the stream'serroreventImpact
Only affects the internal
responseToReadablehelper used byfetch().pipe(). Normal fetch operations are unaffected — this only changes behavior when the response stream encounters an error during reading.Fixes #1443